Continuity mistake: After the Brotherhood of the Cruciform Sword members begin shooting, in the wide shot of the canyon gunfight (with Indy, Henry and Sallah in the right corner of the screen), Vogel is standing behind the tank, shooting at the Brotherhood with his Luger. In the next shot, he's suddenly running with two soldiers. (01:25:47)
Continuity mistake: At the beginning of the movie, in the shot after Roscoe says "He's got our thing!", the lamp behind him and the lamp in front of Fedora disappear. Also, just after Roscoe says that line, immediately his voice is heard saying "Get him!", but his lips don't move. (00:04:44)
Continuity mistake: The remaining Nazi biker passes among his fallen compatriots following Indy. The latter looks over his shoulder at the biker. In the next shot, the background behind the Nazi is totally different (the bodies, the motorbikes and the hut have disappeared). (01:04:53)
Continuity mistake: When Nicola Scott and her soldiers enter the room where Indy and Henry were tied, the window next to the fireplace is on fire. In the next shot, there's no fire there. (01:01:42)
Continuity mistake: The scene when the barrel falls on the TNT box and explodes is flipped (Panama Hat is on the opposite stairs). (00:13:44)
Continuity mistake: In the wide shot of the Nazi convoy, Colonel Vogel can be seen walking alongside a troop truck. In the next shot, he is no longer there. A few seconds later, the colonel appears from the right side of the screen. (01:23:49)
Continuity mistake: When the soldier walks up the steps to attempt the first trial with his sword drawn, in the shots from the front, he's holding the sword on his right side. In the shots from behind, he's holding it on his left side.
Continuity mistake: During the boat chase, after the one boat blows up, another comes up behind Jones and Elsa. Jones starts turning the boat. In the next shot, the man in the boat behind them is shooting at them. They're not turning, they're going straight.
Continuity mistake: Before they make the second fighter pilot crash, Henry hands his bag to Indy. In that shot, the handle of Henry's umbrella is closer to Indy's left shoulder. But, in the next shot from in front of Indy, the handle is closer to his right shoulder. Then, when Henry pulls the umbrella out, the handle is back near Indy's left shoulder.
Continuity mistake: In the cave, young Indy is giving instructions, his hair is down both sides of his face. When he removes the snake saying "It's only a snake", his hair style is changed.
Continuity mistake: The gap between Indy and the chasing motorbikes changes considerably between shots, close to him than far apart the close again and at the checkpoint out of sight.
Continuity mistake: The dirt road the solo motorbike rider takes heading towards Indy is completely different to the road Indy uses just after he knocks the solo rider off.
Continuity mistake: When Indy is on the boat and says "Too small for two of us!", it pans down and you can see the cross halfway out of Indy's pouch. Both of the arms and head are on the outside. Only the bottom half is in his pouch. The bad guy then proceeds to open the pouch, revealing only the top before taking it out.
Continuity mistake: When they first meet, Walter Donovan hands Indiana the glass of champagne almost filled to the brim. The next shot shows Indy's glass with much less champagne in it.
Continuity mistake: Indiana has his satchel on him at the beginning of the 3 challenges and up to the point when he is entering the resting place of the grail. As soon as he enters the cavern where the Knight is, and he stands up, he no longer has the satchel.
Continuity mistake: Young Indy escapes from the four diggers, and you can see them exit the cave after him as he pauses. He moves down to and jumps onto the horse (missing the first time). He gets on the horse and you see the diggers, starting running from the exact same place that they were. It's like they paused their pursuit while the camera was not on them. If they kept running, they would've easily caught up with him before he jumped down.
Continuity mistake: When the boat scene starts, Indy passes by an iron tower. Then he stands to fight the baddie and the boat passes by the tower again.
Continuity mistake: When Henry surprises Marcus in the tank, there is nothing hanging out of the pocket on Marcus' suit. In the next shot, there is now a pendant hanging out of the pocket, but when Marcus shakes Henry's hand in the next shot, the pendant has disappeared.
Continuity mistake: When Indy shoots the 3 Nazis while rescuing his dad, one of them falls and breaks a bench and lands on his right side. When they leave the room, the bench is intact and he's on his left side.
Factual error: When the Nazis are meeting with the Sultan of Hatay he remarks he wants their Rolls Royce Phantom II, he quips about the size of the engine being 4.5L engine with 30HP. In reality, the Phantom II had a 7.7L I-6 engine with 40-50HP. Also, the vehicle shown in the movie is a Rolls-Royce 20/25HP Barker Saloon, not a Phantom II. It also makes little sense that the Nazis would be driving a Rolls Royce since it is a British car. In the novel, the car is said to be a Daimler-Benz, which matches what the Nazis actually used in real life.
Answer: Henry says, in response to Indy asking if he remembered the details of the trials: "I wrote them down in my diary so that I wouldn't have to remember." So, obviously he did NOT know them by heart. Also, as the other answer says, they didn't want the diary to either be in the Nazis' possession or be burned.