Plot hole: After Superman has reversed time the Hoover Dam reverts to its previous undamaged state as it should, but Jimmy Olsen should then have been replaced back on the dam. Instead he interrupts the potential kiss between Lois and Superman and complains of being abandoned by Superman in the desert.
Factual error: When Clark speaks to Jor-El for the first time in the Fortress, Jor-El says "I will have been dead for many thousands of your years..." Fine in theory - Baby Kal-El travelled to Earth at above light speed so time passed differently for him. However, as such, wouldn't Jor-El have seen Earth as it was thousands of years ago? Which also makes there a problem with all the things Kal-El was taught during his voyage to Earth, as Jor-El references Einstein by name, for instance, and he would not have existed at the point when Jor-El sent him to Earth.
Continuity mistake: Kal-El's cradle arrives on earth, flies zooming past the Kents' car, which is driving in the opposite direction and crashes 500 meters behind the vehicle. The car keeps moving for about 200 meters and then pulls over. A brief shot shows an intact curb on the right. However, when Jonathan Kent gets out of the car, everything changes: The cradle has moved 700 meters and lays next to the car; and the immaculate field is now destroyed by a huge ditch.
Visible crew/equipment: Near the beginning when Lois and Clark are walking out of the Daily Planet, Clark gets stuck in the revolving doors. But, look closely at the glass door, and you can see Richard Donner (confirmed in Superman expanded commentary) holding the door so that Christopher Reeve can get stuck.
Continuity mistake: When leaving the Daily Planet for the first time together Clark gets stuck in the revolving door behind Lois. He lets her go through ahead of him and gets in the next section as the door revolves. Cut to the exterior of the Planet when they emerge (just before they meet Rex Reed) and Clark is in the same section of the revolving door as Lois.
Revealing mistake: When Lois is at the heliport, watch the wind flag on the left: when the helicopter arrives, the roaring wind from the vanes makes the flag move up and get stiff. In the close-ups, you keep on hearing the sound but the vanes are off screen. Watch and you'll see the wind flag is down, thus revealing that the engine is off and that the sound we are hearing is fake.
Other mistake: When Superman and Lois are flying through the clouds, there are a number of shots in which we see Superman from Lois' point of view. If you look closely, you can see that Christopher Reeve is not being suspended in these shots, but is, in fact, kneeling to look as though he is flying. You can tell by the profile of the red trunks.